-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swedish #8
Conversation
Thank you for the contribution!
At least, it looks good to me. I'll try to find time to check and merge this during the weekend. BTW, what setup did you use for building? I have only tested Sailfish SDK on Linux with Docker and the latest tooling and targets. Also if you can tell me which device architecture (armv7hl, aarch64, i486) you need, I can build a package with the changes before there is a release. |
Cool, I am using an Xperia 10 V, so aarch64. If I get some time I can try the Docker version (using Virutal Box now) to see if that helps. Don't remember what the issue was at the moment... |
So I switched to Docker and now I can build and run. Switching language makes the app still be English though, even on the main branch. |
Sounds like there is a bug there then. If you want to, you can create an issue about it. Otherwise, I'll do it at some point and hopefully I also have some time to investigate. Just have reinstall the SDK on some computer...
At least when updating translations I have to build it twice for the changes to be effective (see #6). I wonder if there is some issue with adding a new language so one has to force makefile generation or something (for example by removing Makefile files from build directory). I'll check that too when I get around to reviewing this. 🙂 |
One change missing here is to add sv-SE to LANGUAGES in assets/assets.pro. Looks like I forgot to add that to instructions. I can do it after merging too, but of course if you make the change here it will be included. 🙂 I already checked the language and it seems good to me (with my limited Swedish skills), I'll test some more later and merge this then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will merge this, add that change to assets.pro and make a release. 🙂
I decided to publish a new release so you can download the version with Swedish here. |
I have added Swedish translations, but not been able to test since the build process crashes for an unknown reason (no matter branch).
The addition to the pro file might be correct, but needs a double check.